From d15f6a284fbf860687e38dff61d92aecb2fe7438 Mon Sep 17 00:00:00 2001 From: itskovacs Date: Sat, 19 Jul 2025 17:41:46 +0200 Subject: [PATCH] :bug: Fix trip place deletion in plans --- backend/trip/routers/trips.py | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/backend/trip/routers/trips.py b/backend/trip/routers/trips.py index 79b46ec..d72f6a4 100644 --- a/backend/trip/routers/trips.py +++ b/backend/trip/routers/trips.py @@ -293,16 +293,15 @@ def update_tripitem( if db_item.day_id != day_id: raise HTTPException(status_code=400, detail="Bad request") - if item.place: - place_in_trip = any(place.id == item.place for place in db_trip.places) + item_data = item.model_dump(exclude_unset=True) + + place_id = item_data.pop("place", None) + db_item.place_id = place_id + if place_id is not None: + place_in_trip = any(p.id == place_id for p in db_trip.places) if not place_in_trip: raise HTTPException(status_code=400, detail="Bad request") - item_data = item.model_dump(exclude_unset=True) - place_id = item_data.pop("place", None) - if place_id: - db_item.place_id = place_id - for key, value in item_data.items(): setattr(db_item, key, value)